On 03/02/2016 09:04 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Mar 2016 12:40:29 -0300 > Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> escreveu: > >> After all the discussions, I guess "CONN" for connection is the best way >> to represent it. > > Better to put it on a patch. > > Please review. > > Regards, > Mauro > > [media] Better define MEDIA_ENT_F_CONN_* entities > > Putting concepts in a paper is hard, specially since different people > may interpret it in a different way. > > Make clear about the meaning of the MEDIA_ENT_F_CONN_* entities > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > > diff --git a/Documentation/DocBook/media/v4l/media-types.xml b/Documentation/DocBook/media/v4l/media-types.xml > index 5e3f20fdcf17..b036e6103949 100644 > --- a/Documentation/DocBook/media/v4l/media-types.xml > +++ b/Documentation/DocBook/media/v4l/media-types.xml > @@ -46,15 +46,26 @@ > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_RF</constant></entry> > - <entry>Connector for a Radio Frequency (RF) signal.</entry> > + <entry>Entity representing the logical connection associated with a > + single Radio Frequency (RF) signal connector. It > + corresponds to the logical input or output associated > + with the RF signal.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_SVIDEO</constant></entry> > - <entry>Connector for a S-Video signal.</entry> > + <entry>Entity representing the logical connection assowiated > + with a sigle S-Video connector. Such entity should have > + two pads, one for the luminance signal(Y) and one > + for the chrominance signal (C). It corresponds to the > + logical input or output associated with S-Video Y and C > + signals.</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CONN_COMPOSITE</constant></entry> > - <entry>Connector for a RGB composite signal.</entry> > + <entry>Entity representing the logical connection for a composite > + signal. It corresponds to the logical input or output > + associated with the a single signal that carries both > + chrominance and luminance information (Y+C).</entry> > </row> > <row> > <entry><constant>MEDIA_ENT_F_CAM_SENSOR</constant></entry> Finally caught up with RFC discussion. Looks good to me. Thanks for the summary and the patch. Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> In general I agree with the direction to go with property API as it offers flexibility for future enhancements and allows drivers to care about only the properties they need to support. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@xxxxxxxxxxxxxxx | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
