Re: Problem since commit c73bbaa4ec3e [rc-core: don't lock device at rc_register_device()]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Sat, 27 Feb 2016 17:10:41 +0100
Heiner Kallweit <hkallweit1@xxxxxxxxx> escreveu:

> Am 27.02.2016 um 13:14 schrieb Heiner Kallweit:
> > Since this commit I see the following error when the Nuvoton RC driver is loaded:
> > 
> > input: failed to attach handler kbd to device input3, error: -22
> > 
> > Error 22 (EINVAL) comes from the new check in rc_open().
> >   
> 
> Complete call chain seems to be:
>   rc_register_device
>   input_register_device
>   input_attach_handler
>   kbd_connect
>   input_open_device
>   ir_open
>   rc_open
> 
> rc_register_device calls input_register_device before dev->initialized = true,
> therefore the new check in rc_open fails. At a first glance I'd say that we have
> to remove this check from rc_open.

Hmm... maybe we could, instead, do:

	if (!rdev->initialized) {
		rval = -ERESTARTSYS;
		goto unlock;
	}



> 
> Regards, Heiner
> 


-- 
Thanks,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux