re: V4L/DVB (3692): Keep experimental SLICED_VBI defines under an #if 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans Verkuil,

The patch 9bc7400a9d01: "V4L/DVB (3692): Keep experimental SLICED_VBI
defines under an #if 0" from Mar 29, 2006, leads to the following
static checker warning:

	drivers/media/i2c/tvp5150.c:719 tvp5150_get_vbi()
	error: buffer overflow regs 5 <= 14

drivers/media/i2c/tvp5150.c
   716                  }
   717                  pos = ret & 0x0f;
   718                  if (pos < 0x0f)
   719                          type |= regs[pos].type.vbi_type;

It used to be that regs[] had 0x10 elements (or 0xf if you don't count
the empty element at the end), but we ifdef zero most of them so now
we're reading beyond the end of the array.

   720          }
   721  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux