Hello, On Wed, Feb 17, 2016 at 2:43 AM, Jung Zhao <jung.zhao@xxxxxxxxxxxxxx> wrote: > + dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &attrs_novm); > + vpu->alloc_ctx = vb2_dma_contig_init_ctx_attrs(&pdev->dev, > + &attrs_novm); > + if (IS_ERR(vpu->alloc_ctx)) { > + ret = PTR_ERR(vpu->alloc_ctx); > + goto err_dma_contig; > + } > + > + vpu->alloc_ctx_vm = vb2_dma_contig_init_ctx(&pdev->dev); > + if (IS_ERR(vpu->alloc_ctx_vm)) { > + ret = PTR_ERR(vpu->alloc_ctx_vm); > + goto err_dma_contig_vm; > + } I'm not qualified to review this whole driver, so just adding my $0.02... Could you please fold <https://chromium-review.googlesource.com/322336> into your patch submission? All of the necessary patches have landed in RMK's tree upstream and are currently present in linuxnext. Thanks! -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html