Em Mon, 08 Feb 2016 16:00:26 -0700
Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> escreveu:
> >>> + ret = __media_entity_pipeline_start(entity, pipe);
> >>> + if (ret) {
> >>> + pr_err("Start Pipeline: %s->%s Error %d\n",
> >>> + source->name, entity->name, ret);
> >>> + ret = __media_entity_setup_link(found_link, 0);
> >>> + pr_err("Deactive link Error %d\n", ret);
> >>> + goto end;
> >>> + }
> >>
> >> Hmm... isn't it to early to activate the pipeline here? My original
> >> guess is that, on the analog side, this should happen only at the stream
> >> on code. Wouldn't this break apps like mythTV?
>
> On analog side, there are a few ioctls that
> change the configuration on the tuner way
> before stream on step. Is there a reason to
> separate the setup_link() and pipeline_start()
> steps? I can separate these two steps, but I
> am not really seeing the reason for that.
I'm actually ok with that, provided that it won't break existing
apps. Did you test it with MythTV?
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
