On Wed, Jan 27, 2016 at 03:05:16PM +0100, Hans Verkuil wrote: > On 01/27/16 14:50, Sakari Ailus wrote: > > When the Media controller framework was merged, it was decided not to add > > pipeline power management code for it was not seen generic. As a result, a > > number of drivers have copied the same piece of code, with same bugfixes > > done to them at different points of time (or not at all). > > > > Add these functions to V4L2. Their use is optional for drivers. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > drivers/media/v4l2-core/v4l2-common.c | 174 ++++++++++++++++++++++++++++++++++ > > include/media/v4l2-common.h | 37 ++++++++ > > I think I would prefer to see a v4l2-mc.c source rather than adding it to common. > Since this is specific to both v4l2 and MC it only has to be compiled > if both config options are set. > > Besides, I think we need to move more common mc code to such a file. Ok. I'll move these to a separate file. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html