This reverts commit a8f29e89f2b54fbf2c52be341f149bc195b63a8b. This commit handled drivers failing to issue a spac which causes sequences of mark-mark-space instead of the expected space-mark-space-mark... The fix added an extra space for each and every timeout which fixes the problem for the failing drivers. However, for existing working drivers it the added space causes mark-space-space sequences in the output which break userspace rightfully expecting space-mark-space-mark... Thus, the fix is broken and reverted. The fix is discussed in https://bugzilla.redhat.com/show_bug.cgi?id=1260862. In particular, the original committer Austin Lund agrees. Signed-off-by: Alec Leamas <leamas.alec@xxxxxxxxx> --- drivers/media/rc/ir-lirc-codec.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 5effc65..8984b33 100644 --- a/drivers/media/rc/ir-lirc-codec.c +++ b/drivers/media/rc/ir-lirc-codec.c @@ -39,17 +39,11 @@ static int ir_lirc_decode(struct rc_dev *dev, struct ir_raw_event ev) return -EINVAL; /* Packet start */ - if (ev.reset) { - /* Userspace expects a long space event before the start of - * the signal to use as a sync. This may be done with repeat - * packets and normal samples. But if a reset has been sent - * then we assume that a long time has passed, so we send a - * space with the maximum time value. */ - sample = LIRC_SPACE(LIRC_VALUE_MASK); - IR_dprintk(2, "delivering reset sync space to lirc_dev\n"); + if (ev.reset) + return 0; /* Carrier reports */ - } else if (ev.carrier_report) { + if (ev.carrier_report) { sample = LIRC_FREQUENCY(ev.carrier); IR_dprintk(2, "carrier report (freq: %d)\n", sample); -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
