Hi Sakari, On Friday 22 January 2016 15:36:47 Sakari Ailus wrote: > Laurent Pinchart wrote: > > On Tuesday 08 December 2015 17:15:15 Sakari Ailus wrote: > >> Also mark which format definitions are compat definitions for the > >> pre-existing codes. This way we don't end up listing the same formats > >> twice. > > > > Wouldn't it be easier to add a function to return the whole array (and > > terminate it with an empty entry to avoid having to return both the array > > and the length=) ? > > Now that I'm actually thinking about making that change, I have a few > concerns: > > - This is not in line with the other APIs in the library, they mirror > the IOCTL behaviour (it's another debate whether this is a good idea or > not). A function to list the library's supported pixel codes wouldn't be either, so I don't really see that as a big issue. A bigger issue, that needs to be fixed to release a version of the library as a shared object, is that the API hasn't really been thought of properly. > - I need a new statically allocated array for that. I think I'll change > my sed script. Allocating an array when the function is called the first > time isn't a great idea either, there's a problem with re-entrancy and > it's a memory leak, too. In a shared object we could make use the _init and _fini functions. Is there something similar available for static libraries ? A different sed script should be fine too. > So don't complain about these when I send an updated version. ;-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
