Re: [PATCH] adv7604: fix SPA register location for ADV7612

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/19/2016 01:17 PM, Ulrich Hecht wrote:
> SPA location LSB register is at 0x70.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> ---
>  drivers/media/i2c/adv7604.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 3787f81..f78d36c 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -2149,6 +2149,10 @@ static int adv76xx_set_edid(struct v4l2_subdev *sd, struct v4l2_edid *edid)
>  	if (info->type == ADV7604) {
>  		rep_write(sd, 0x76, spa_loc & 0xff);
>  		rep_write_clr_set(sd, 0x77, 0x40, (spa_loc & 0x100) >> 2);
> +	} else if (info->type == ADV7612) {
> +		/* ADV7612 Software Manual Rev. A, p. 15 */
> +		rep_write(sd, 0x70, spa_loc & 0xff);

That should just go onto the else branch and replace the FIXME.

> +		rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
>  	} else {
>  		/* FIXME: Where is the SPA location LSB register ? */
>  		rep_write_clr_set(sd, 0x71, 0x01, (spa_loc & 0x100) >> 8);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux