Hi Geert-san,
2016-01-12 3:19 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Kaneko-san,
>
> On Mon, Jan 11, 2016 at 7:00 PM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>> --- a/drivers/media/platform/soc_camera/rcar_vin.c
>> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
>> @@ -143,6 +143,7 @@
>> #define RCAR_VIN_BT656 (1 << 3)
>>
>> enum chip_id {
>> + RCAR_GEN3,
>> RCAR_GEN2,
>> RCAR_H1,
>> RCAR_M1,
>> @@ -1818,6 +1819,8 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
>>
>> #ifdef CONFIG_OF
>> static const struct of_device_id rcar_vin_of_table[] = {
>> + { .compatible = "renesas,rcar-gen2-vin", .data = (void *)RCAR_GEN2 },
>> + { .compatible = "renesas,rcar-gen3-vin", .data = (void *)RCAR_GEN3 },
>
> Please add the generic compatible values at the end of the list, so SoC-specific
> ones take precedence.
Oh, that makes sense.
I will fix it soon.
Thanks,
kaneko
>
>> { .compatible = "renesas,vin-r8a7794", .data = (void *)RCAR_GEN2 },
>> { .compatible = "renesas,vin-r8a7793", .data = (void *)RCAR_GEN2 },
>> { .compatible = "renesas,vin-r8a7791", .data = (void *)RCAR_GEN2 },
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
