Hi Javier, On Thu, Jan 07, 2016 at 03:27:20PM -0300, Javier Martinez Canillas wrote: > The v4l2_of_parse_endpoint() function can fail so check the return value. > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> > --- > > drivers/media/i2c/tvp7002.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c > index 83c79fa5f61d..4aac303da5d4 100644 > --- a/drivers/media/i2c/tvp7002.c > +++ b/drivers/media/i2c/tvp7002.c > @@ -905,11 +905,13 @@ tvp7002_get_pdata(struct i2c_client *client) > if (!endpoint) > return NULL; > > + if (v4l2_of_parse_endpoint(endpoint, &bus_cfg)) pdata is uninitialised here. There are many ways to fix this but I think I'd just assign it to NULL in variable declaration. > + goto done; > + > pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL); > if (!pdata) > goto done; > > - v4l2_of_parse_endpoint(endpoint, &bus_cfg); > flags = bus_cfg.bus.parallel.flags; > > if (flags & V4L2_MBUS_HSYNC_ACTIVE_HIGH) -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
