Hi! The rcar_vin driver relies on this method. The second patch makes sure that they return up-to-date data if the input signal has changed since initialization. This revision implements .get_selection instead of .g_crop/.cropcap and includes the suggested style changes. It has been tested with the rcar_vin driver together with Hans Verkuil's "v4l2: remove g/s_crop and cropcap from video ops" patch: https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=rmcrop&id=9ff32166c29d1323db090d638da27ea652d1d4d8 CU Uli Ulrich Hecht (2): media: adv7604: implement get_selection media: adv7604: update timings on change of input signal drivers/media/i2c/adv7604.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html