Hi, 2015-12-14 2:43 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>: > On 12/13/2015 06:27 PM, Yoshihiro Kaneko wrote: > >> From: Yoshihiko Mori <yoshihiko.mori.nx@xxxxxxxxxxx> >> >> Add chip identification for R-Car Gen3. >> >> Signed-off-by: Yoshihiko Mori <yoshihiko.mori.nx@xxxxxxxxxxx> >> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > [...] >> >> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c >> b/drivers/media/platform/soc_camera/rcar_vin.c >> index 5d90f39..29e7ca4 100644 >> --- a/drivers/media/platform/soc_camera/rcar_vin.c >> +++ b/drivers/media/platform/soc_camera/rcar_vin.c >> @@ -143,6 +143,7 @@ >> #define RCAR_VIN_BT656 (1 << 3) >> >> enum chip_id { >> + RCAR_GEN3, >> RCAR_GEN2, >> RCAR_H1, >> RCAR_M1, >> @@ -1846,6 +1847,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops >> = { >> >> #ifdef CONFIG_OF >> static const struct of_device_id rcar_vin_of_table[] = { >> + { .compatible = "renesas,vin-r8a7795", .data = (void *)RCAR_GEN3 >> }, > > > I don't see where this is checked in the driver. Shouldn't we just use > gen2? I'd like to withdraw this patch now. I intend to post the series patch including this patch at another day. > > MBR, Sergei > Thanks, kaneko -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html