Hi, Thanks for your feedback. On Saturday, December 12, 2015 17:40:07 Laurent Pinchart wrote: > I wonder if there's really a point calling video_free_buffers() in the > error case. The function will return an error causing the caller to > close the device, which will free the buffers. There are other > locations in yavta after buffers are allocated where the buffers are not > freed in the error path. What would you think of just replacing the > goto done statements by a return ret ? I'm fine with that change. It will also simplify the patch. I'll submit a new version of the patch. - Tuukka -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html