Hi Ulrich,
Thank you for the patch.
On Friday 11 December 2015 17:04:51 Ulrich Hecht wrote:
> The rcar_vin driver relies on this.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> ---
> drivers/media/i2c/adv7604.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 129009f..d30e7cc 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -1885,6 +1885,17 @@ static int adv76xx_get_format(struct v4l2_subdev *sd,
> return 0;
> }
>
> +static int adv76xx_g_crop(struct v4l2_subdev *sd, struct v4l2_crop *a)
> +{
> + struct adv76xx_state *state = to_state(sd);
> +
> + a->c.height = state->timings.bt.height;
> + a->c.width = state->timings.bt.width;
Shouldn't you set a->c.top and a->c.left to 0 ? There's no guarantee that the
caller will always zero the structure before calling you.
> + a->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
The type field is an input parameter, you should just return -EINVAL if the
value is not V4L2_BUF_TYPE_VIDEO_CAPTURE.
> +
> + return 0;
> +}
> +
> static int adv76xx_set_format(struct v4l2_subdev *sd,
> struct v4l2_subdev_pad_config *cfg,
> struct v4l2_subdev_format *format)
> @@ -2407,6 +2418,7 @@ static const struct v4l2_subdev_core_ops
> adv76xx_core_ops = {
>
> static const struct v4l2_subdev_video_ops adv76xx_video_ops = {
> .s_routing = adv76xx_s_routing,
> + .g_crop = adv76xx_g_crop,
> .g_input_status = adv76xx_g_input_status,
> .s_dv_timings = adv76xx_s_dv_timings,
> .g_dv_timings = adv76xx_g_dv_timings,
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
