Hi Mauro, Thank you for the patch. On Sunday 30 August 2015 00:06:46 Mauro Carvalho Chehab wrote: > X-Patchwork-Delegate: m.chehab@xxxxxxxxxxx > This sensor driver is abusing MEDIA_ENT_T_V4L2_SUBDEV, creating > some subdevs with a non-existing type. > > As this is a sensor driver, the proper type is likely > MEDIA_ENT_T_V4L2_SUBDEV_SENSOR. That's actually not correct. The driver creates two subdevs, one for the image sensor pixel array (and the related readout logic) and one for an ISP. The first subdev already uses the MEDIA_ENT_T_V4L2_SUBDEV_SENSOR type, but the second subdev isn't a sensor pixel array. > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > > diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c > index d3bff30bcb6f..0513196bd48c 100644 > --- a/drivers/media/i2c/s5k5baf.c > +++ b/drivers/media/i2c/s5k5baf.c > @@ -1919,7 +1919,7 @@ static int s5k5baf_configure_subdevs(struct s5k5baf > *state, > > state->pads[PAD_CIS].flags = MEDIA_PAD_FL_SINK; > state->pads[PAD_OUT].flags = MEDIA_PAD_FL_SOURCE; > - sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV; > + sd->entity.type = MEDIA_ENT_T_V4L2_SUBDEV_SENSOR; > ret = media_entity_init(&sd->entity, NUM_ISP_PADS, state->pads); > > if (!ret) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
