Re: [PATCH 3/4] si2165: cleanup logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthias,

[auto build test ERROR on v4.3-rc7]
[also build test ERROR on next-20151113]

url:    https://github.com/0day-ci/linux/commits/Matthias-Schwarzott/cx231xx_dvb-use-demod_i2c-for-demod-attach/20151114-065917
config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

Note: the linux-review/Matthias-Schwarzott/cx231xx_dvb-use-demod_i2c-for-demod-attach/20151114-065917 HEAD 92eaa21d1f22e14d623c057e06ab9d5035f6df7b builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/media/dvb-frontends/si2165.c: In function 'si2165_set_parameters':
>> drivers/media/dvb-frontends/si2165.c:886:39: error: 'val' undeclared (first use in this function)
     ret = si2165_readreg8(state, 0x0341, val);
                                          ^
   drivers/media/dvb-frontends/si2165.c:886:39: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/media/dvb-frontends/si2165.c:905:3: error: label 'error' used but not defined
      goto error;
      ^

vim +/val +886 drivers/media/dvb-frontends/si2165.c

3e54a169 Matthias Schwarzott 2014-07-22  880  	/* recalc if_freq_shift if IF might has changed */
b480ae7b Matthias Schwarzott 2015-11-13  881  	ret = si2165_set_if_freq_shift(state);
3e54a169 Matthias Schwarzott 2014-07-22  882  	if (ret < 0)
3e54a169 Matthias Schwarzott 2014-07-22  883  		return ret;
3e54a169 Matthias Schwarzott 2014-07-22  884  
3e54a169 Matthias Schwarzott 2014-07-22  885  	/* boot/wdog status */
3e54a169 Matthias Schwarzott 2014-07-22 @886  	ret = si2165_readreg8(state, 0x0341, val);
3e54a169 Matthias Schwarzott 2014-07-22  887  	if (ret < 0)
3e54a169 Matthias Schwarzott 2014-07-22  888  		return ret;
3e54a169 Matthias Schwarzott 2014-07-22  889  	ret = si2165_writereg8(state, 0x0341, 0x00);
3e54a169 Matthias Schwarzott 2014-07-22  890  	if (ret < 0)
3e54a169 Matthias Schwarzott 2014-07-22  891  		return ret;
3e54a169 Matthias Schwarzott 2014-07-22  892  	/* reset all */
3e54a169 Matthias Schwarzott 2014-07-22  893  	ret = si2165_writereg8(state, 0x00c0, 0x00);
3e54a169 Matthias Schwarzott 2014-07-22  894  	if (ret < 0)
3e54a169 Matthias Schwarzott 2014-07-22  895  		return ret;
3e54a169 Matthias Schwarzott 2014-07-22  896  	/* gp_reg0 */
3e54a169 Matthias Schwarzott 2014-07-22  897  	ret = si2165_writereg32(state, 0x0384, 0x00000000);
3e54a169 Matthias Schwarzott 2014-07-22  898  	if (ret < 0)
3e54a169 Matthias Schwarzott 2014-07-22  899  		return ret;
b480ae7b Matthias Schwarzott 2015-11-13  900  
b480ae7b Matthias Schwarzott 2015-11-13  901  	/* write adc values after each reset*/
b480ae7b Matthias Schwarzott 2015-11-13  902  	ret = si2165_write_reg_list(state, agc_rewrite,
b480ae7b Matthias Schwarzott 2015-11-13  903  				    ARRAY_SIZE(agc_rewrite));
b480ae7b Matthias Schwarzott 2015-11-13  904  	if (ret < 0)
b480ae7b Matthias Schwarzott 2015-11-13 @905  		goto error;
b480ae7b Matthias Schwarzott 2015-11-13  906  
3e54a169 Matthias Schwarzott 2014-07-22  907  	/* start_synchro */
3e54a169 Matthias Schwarzott 2014-07-22  908  	ret = si2165_writereg8(state, 0x02e0, 0x01);

:::::: The code at line 886 was first introduced by commit
:::::: 3e54a1697ace99d1ad602ec268abf117ace1412f [media] si2165: Add demod driver for DVB-T only

:::::: TO: Matthias Schwarzott <zzam@xxxxxxxxxx>
:::::: CC: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux