Hi Mauro, On Wed, Oct 28, 2015 at 09:43:43AM +0900, Mauro Carvalho Chehab wrote: > Em Tue, 27 Oct 2015 01:01:38 +0200 > Sakari Ailus <sakari.ailus@xxxxxx> escreveu: > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Please add some documentation at the body for all patches. > > Btw, IMHO, it would be best to fold this patch and the following ones > that are related to media_entity_graph_walk_init() altogether, as it > makes easier to review if all places were covered. I think patches such as the 8th are easier to review as they are. For the coverage, $ git grep -l -E '^ *media_entity_graph_walk_start' Documentation/media-framework.txt drivers/media/media-entity.c drivers/media/platform/exynos4-is/media-dev.c drivers/media/platform/omap3isp/isp.c drivers/media/platform/omap3isp/ispvideo.c drivers/media/platform/vsp1/vsp1_video.c drivers/media/platform/xilinx/xilinx-dma.c drivers/staging/media/davinci_vpfe/vpfe_video.c drivers/staging/media/omap4iss/iss.c drivers/staging/media/omap4iss/iss_video.c Which suggests that I'm probably missing a few patches, indeed. I'll take that into account in the next submission. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html