On Thu, Oct 15, 2015 at 4:22 PM, Insu Yun <wuninsu@xxxxxxxxx> wrote: > Return values of mxl111sf_enable_usb_output and mxl1x1sf_top_master_ctrl > are not validated. > > Signed-off-by: Insu Yun <wuninsu@xxxxxxxxx> Eeek! You're right! ...and I'm the one who wrote the offending code. My bad O:-) Thank you for this patch. Mauro, please apply it. Reviewed-by: Michael Ira Krufky <mkrufky@xxxxxxxxxxx> > --- > drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c > index bec12b0..b71b2e6 100644 > --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c > +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c > @@ -288,9 +288,9 @@ static int mxl111sf_adap_fe_init(struct dvb_frontend *fe) > err = mxl1x1sf_set_device_mode(state, adap_state->device_mode); > > mxl_fail(err); > - mxl111sf_enable_usb_output(state); > + err = mxl111sf_enable_usb_output(state); > mxl_fail(err); > - mxl1x1sf_top_master_ctrl(state, 1); > + err = mxl1x1sf_top_master_ctrl(state, 1); > mxl_fail(err); > > if ((MXL111SF_GPIO_MOD_DVBT != adap_state->gpio_mode) && > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
