Re: [PATCH] rtl28xxu: fix control message flaws

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/15/2015 01:11 AM, Daniel Glöckner wrote:
On Sat, Oct 10, 2015 at 07:45:30PM +0300, Antti Palosaari wrote:
Add lock to prevent concurrent access for control message as control
message function uses shared buffer. Without the lock there may be
remote control polling which messes the buffer causing IO errors.

This patch fixes the Problems I had with my Astrometa stick's I2C bus
locking up at the end of each dvbv5-scan run until it is disconnected.
There is another source of IO errors in the current driver, though.
The delayed work closing the I2C gate to the tuner is often executed
after rtl2832_power_ctrl has disabled the PLL. This will cause the
USB transfer accessing the gate control register to fail with -EPIPE.

I saw that few times too, but it does not cause any other harm than error printing. It went away when canceled that delayed gate closing timer during demod sleep. But that was device which doesn't have slave demod at all, so it does not apply to your case as integrated demod sleep is not called at all. I think some callback which does opposite than "enable_slave_ts()" is needed. Like "disable_slave_ts()" which kills that timer before demod is powered off.

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux