Re: [RFC PATCH] media: uvc: *HACK* workaround uvc unregister device *HACK*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Sorry to follow up on an old message, but:

On Fri, 31 Oct 2014 19:41:33 +0900,
Laurent Pinchart wrote:
> 
> On Thursday 02 October 2014 18:09:47 Michael Grzeschik wrote:
> > Currently the uvc_driver is not cleaning up its child devices if a
> > device is still in use. It leads to orphaned devices which are not
> > sitting on any interface. They get cleaned up on uvc_delete which will
> > be called on uvc_remove after the userspace application is closing the
> > stream. When PM_RUNTIME is used in the kernel, this leads to the
> > following backtrace for missing sysfs entries in the orphaned kobjects.
> > 
> > This patch is moving the device cleanup code for the child devices from
> > uvc_delete to uvc_unregister_video. It is an *HACK* workaround which
> > is ment to initiate the discussion for a proper solution.
> 
> Does https://patchwork.linuxtv.org/patch/26561/ help ? The usb_put_intf() and 
> usb_put_dev() calls could be moved to the end of the function to fix the 
> media_device_unregister() warning.

26561 does not seem to help, since I can reproduce the warning on 4.2.1

	4.2.0-1-amd64 #1 SMP Debian 4.2.1-2 (2015-09-27) x86_64 GNU/Linux

I haven't tried Michael's yet, but it seems, at least to me, that many
subsystem are having similar problem and proper fixes must be applied
per subsystem.  Is that the case right now?

ref:
  - https://bugzilla.redhat.com/show_bug.cgi?id=1174075
  - http://thread.gmane.org/gmane.linux.usb.general/119218/focus=85560
    - mention that this "is not new"
  - http://thread.gmane.org/gmane.linux.scsi/86237/focus=88328
-- 
             yashi


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux