Re: [git:media_tree/master] [media] rcar_vin: call g_std() instead of querystd()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 9/27/2015 11:08 PM, Mauro Carvalho Chehab wrote:

This is an automatic generated email to let you know that the following
patch were queued at the
http://git.linuxtv.org/cgit.cgi/media_tree.git tree:

Subject: [media] rcar_vin: call g_std() instead of querystd()
Author:  Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Date:    Thu Sep 3 20:18:05 2015 -0300

Hans Verkuil says: "The only place querystd can be called  is in the
QUERYSTD
ioctl, all other ioctls should use the last set standard." So call the
g_std()
subdevice method instead of querystd() in the driver's set_fmt() method.

Reported-by: Hans Verkuil <hverkuil@xxxxxxxxx>
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>

    Note that merging this patch without the 2 patches preceding it in the the
series will break the frame capture.

Ouch, the other 2 patches were not for me, I wasn't even CC'ed on them,
but I guess I should have read patch 0/3, on which I was indeed CC'ed and
just have acked this patch instead of pushing it... Mauro, I guess the
only two possibilities to fix this now is to also push the other two
patches or to revert this one. Sorry about this.

Well, if the other two patches are OK, then send me a pull request,
and I'll merge them.

The adv7180 patch was rejected by Hans. I'm still hoping Lars-Peter will look into removing the auto-detect feature from this driver.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux