On 08/30/2015 05:06 AM, Mauro Carvalho Chehab wrote:
> The media_entity_add_link() function takes an entity
> as an argument just to get the list head.
>
> Make it more generic by changing the function argument
> to list_head.
>
> No functional changes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
> index ff63201443d7..6d06be6c9ef3 100644
> --- a/drivers/media/media-entity.c
> +++ b/drivers/media/media-entity.c
> @@ -580,7 +580,7 @@ EXPORT_SYMBOL_GPL(media_entity_put);
> * Links management
> */
>
> -static struct media_link *media_entity_add_link(struct media_entity *entity)
> +static struct media_link *media_add_link(struct list_head *head)
> {
> struct media_link *link;
>
> @@ -588,7 +588,7 @@ static struct media_link *media_entity_add_link(struct media_entity *entity)
> if (link == NULL)
> return NULL;
>
> - list_add_tail(&link->list, &entity->links);
> + list_add_tail(&link->list, head);
>
> return link;
> }
> @@ -607,7 +607,7 @@ media_create_pad_link(struct media_entity *source, u16 source_pad,
> BUG_ON(source_pad >= source->num_pads);
> BUG_ON(sink_pad >= sink->num_pads);
>
> - link = media_entity_add_link(source);
> + link = media_add_link(&source->links);
> if (link == NULL)
> return -ENOMEM;
>
> @@ -622,7 +622,7 @@ media_create_pad_link(struct media_entity *source, u16 source_pad,
> /* Create the backlink. Backlinks are used to help graph traversal and
> * are not reported to userspace.
> */
> - backlink = media_entity_add_link(sink);
> + backlink = media_add_link(&sink->links);
> if (backlink == NULL) {
> __media_entity_remove_link(source, link);
> return -ENOMEM;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
