Em Tue, 25 Aug 2015 09:33:15 +0200 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote: > > Remove entity name from the link as this exists only if the object > > type is PAD on both link ends. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> > > I am wondering whether it should detect if this is a pad-to-pad link > or an interface-to-entity link and log this accordingly. > > But I think that is better done as a follow-up patch if we think this > is useful. I actually opted to keep the function more generic. We may latter add a per-type specific log here, if needed, but we can always grep at the logs to get the entity or interface name. > So for this patch: > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > > > > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > > index 9ec9c503caca..5788297cd500 100644 > > --- a/drivers/media/media-entity.c > > +++ b/drivers/media/media-entity.c > > @@ -106,14 +106,12 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj) > > struct media_link *link = gobj_to_link(gobj); > > > > dev_dbg(gobj->mdev->dev, > > - "%s: id 0x%08x link#%d: '%s' %s#%d ==> '%s' %s#%d\n", > > + "%s: id 0x%08x link#%d: %s#%d ==> %s#%d\n", > > event_name, gobj->id, media_localid(gobj), > > > > - link->source->entity->name, > > gobj_type(media_type(&link->source->graph_obj)), > > media_localid(&link->source->graph_obj), > > > > - link->sink->entity->name, > > gobj_type(media_type(&link->sink->graph_obj)), > > media_localid(&link->sink->graph_obj)); > > break; > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
