Hello Hans, On 08/20/2015 02:41 PM, Hans Verkuil wrote: > On 08/19/15 17:35, Javier Martinez Canillas wrote: >> Hello, >> >> This series contains a couple of build fixes and cleanups for the >> Media Controller framework. The goal of the series is to get rid of >> the struct media_entity .parent member since now that a media_gobj is >> embedded into entities, the media_gobj .mdev member can be used to >> store a pointer to the parent struct media_device. >> >> So the .parent field becomes redundant and can be removed after all >> the users are converted to use entity .graph_obj.mdev instead. >> >> Patches 1/4 and 2/4 are build fixes I found while build testing if no >> regressions were introduced by the conversion. Patch 3/4 converts >> all the drivers and the MC core to use .mdev instead of .parent and >> finally patch 4/4 removes the .parent field since now is unused. > > Regarding patches 1 and 2: these should of course be merged with Mauro's > patches that make this particular change (patch 3/8), otherwise it would > break git bisect. > > Anyway, > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> for the changes in patch Thanks a lot for the acks. > 1 and 2, as long as they are added to Mauro's patch 3/8. > Indeed, I completely agree that these should be squashed with Mauro's patch to maintain git bisect-ability. > Regards, > > Hans > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
