Re: [PATCH RFC v3 14/16] media: add a generic function to remove a link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Wed, 12 Aug 2015 14:45:52 -0600
Shuah Khan <shuahkhan@xxxxxxxxx> escreveu:

> On Wed, Aug 12, 2015 at 2:14 PM, Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxxxxxxx> wrote:
> > Removing a link is simple. Yet, better to have a separate
> > function for it, as we'll be also sharing it with a
> > public API call.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
> 
> One thing to think about is whether or not we need some kind of callback
> mechanism to alert the entity on the other side of the link and other entities
> associated with the media device when a link is removed.
> 
> This patch is fine for now and we can enhance it as and when we have the
> need for such notifications.

Well, now, all elements of the graph are of the type media_graph_obj.

One of the things it is stored there is the media_device. It would
be very easy to add a notify function[1] that would call a callback
when a new object is created or removed. A single callback function
could be used for any topology change.

So, I think that it is now simpler to track topology changes than
before ;)

[1] Actually, I would implement a list with notification callbacks
as more than one driver may want to be notified about topology
changes.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux