Re: [PATCH 1/1] Staging: media: davinci_vpfe: fix over 80 characters coding style issue.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/06/2015 11:45 PM, Sudip Mukherjee wrote:
> On Thu, Aug 06, 2015 at 09:55:54PM -0500, Junsu Shin wrote:
>>  This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by checkpatch.pl.
>>  Signed-off-by: Junsu Shin <jjunes0@xxxxxxxxx>
> please do not use whitespace before Signed-off-by: line.
>>
>> ---
>>  drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> index 1bbb90c..57cd274 100644
>> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>>   * @fse: pointer to v4l2_subdev_frame_size_enum structure.
>>   */
>>  static int
>> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
>> -			  struct v4l2_subdev_frame_size_enum *fse)
>> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
>> +			struct v4l2_subdev_pad_config *cfg,
>> +			struct v4l2_subdev_frame_size_enum *fse)
> since you are modifying this line, please fix up the indention also.
> 
> regards
> sudip
> 

Thanks for pointing it out.
Again, this is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected by the script.
This time I fixed up the indentation issue claimed in the previous one.
Signed-off-by: Junsu Shin <jjunes0@xxxxxxxxx>
---
 drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 1bbb90c..a474adf 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
  * @fse: pointer to v4l2_subdev_frame_size_enum structure.
  */
 static int
-ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
-			  struct v4l2_subdev_frame_size_enum *fse)
+ipipe_enum_frame_size(struct v4l2_subdev *sd,
+		       struct v4l2_subdev_pad_config *cfg,
+		       struct v4l2_subdev_frame_size_enum *fse)
 {
 	struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
 	struct v4l2_mbus_framefmt format;
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux