Hi, Laurent On 8/1/2015 5:22 PM, Laurent Pinchart wrote:
Fix a compilation warning by removing an unused local variable in the probe function. Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> --- drivers/media/platform/soc_camera/atmel-isi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 9c900d9569e0..a2e50a734fa3 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -920,7 +920,6 @@ static int atmel_isi_probe(struct platform_device *pdev) struct atmel_isi *isi; struct resource *regs; int ret, i; - struct device *dev = &pdev->dev;
After a further check, I find this patch should be squashed with the [PATCH 3/4]. Since 'dev' is used by platform data in atmel_isi_probe() function by following code:
pdata = dev->platform_data; if ((!pdata || !pdata->data_width_flags) && !pdev->dev.of_node) { dev_err(&pdev->dev, "No config available for Atmel ISI\n"); return -EINVAL; } So if you agree with it, I will squash this patch with [PATCH 3/4] Remove support for platform data in my tree. Does it sound ok for you? Best Regards, Josh Wu
struct soc_camera_host *soc_host; struct isi_platform_data *pdata;
-- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html