On Tue, 04 Aug 2015 19:04:36 +0200 Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes: > > >> include/linux/scatterlist.h | 5 ++ > >> lib/scatterlist.c | 189 ++++++++++++++++++++++++++++++++++++++++++++ > >> 2 files changed, 194 insertions(+) > > > > It's quite a bit of code for a fairly specialised thing. How ugly > > would it be to put this in a new .c file and have subsystems select it > > in Kconfig? > I have no idea about the "ugliness", but why not ... > > If nobody objects, and in order to submit a proper patch, there are decisions to > make : > - what will be the scope of this new .c file ? > - only sg_plit() ? > - all sg specialized functions, ie. sg_lib.c ? Just sg_split I'd say. It's a logical unit. Other things can be moved elsewhere later as cleanups/optimisations, but that's all off-topic. > - will include/linux/scatterlist.h have an "ifdefed" portion for what X.c > offers ? I prefer to avoid the ifdefs. This means that the error is reported at link-time rather than compile-time but that's a pretty small cost and it's a once-off inconvenience, whereas messy/complex header files are permanent. > - what naming for X.c and the config entry ? um, CONFIG_SG_SPLIT and sg_split.c? > What about adding this to lib/Makefile, and one ifdef to scatterlist.h ? : > obj-$(CONFIG_SG_LIB) += sg_lib.o It would be obj-$(CONFIG_SG_SPLIT) += sg_split.o -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
