A nit only, I'm afraid: a license mismatch. On ma, 2015-07-06 at 13:40 +0200, Benjamin Gaignard wrote: > --- /dev/null > +++ b/drivers/smaf/smaf-core.c > + * License terms: GNU General Public License (GPL), version 2 > +MODULE_LICENSE("GPL"); The comment at the top of this file states, succinctly, that the license is GPL v2. And, according to include/linux/module.h, the MODULE_LICENSE() macro here states that the license is GPL v2 or later. So I think that either that comment or the ident used in that macro needs to change. Ditto for 2/2. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html