Hi Guennadi, This is the next round. Most of your comments are addressed or answered, the one big thing left apart is the videobuf_sg_cut() implementation and complexity. If you have a better idea, I'm all ears. One thing that changed since v1 is that pxa_dma driver was accepted into dmaengine tree and merged, as well as the dma buffer "reusability" stuff. This begins round 2 of dmaengine conversion of pxa_camera, happy review. Cheers. -- Robert Robert Jarzmik (4): media: pxa_camera: fix the buffer free path media: pxa_camera: move interrupt to tasklet media: pxa_camera: trivial move of dma irq functions media: pxa_camera: conversion to dmaengine drivers/media/platform/soc_camera/pxa_camera.c | 522 +++++++++++++------------ 1 file changed, 267 insertions(+), 255 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html