From: Hans Verkuil <hans.verkuil@xxxxxxxxx> While normal video/radio/vbi/swradio nodes have a proper QUERYCAP ioctl that apps can call to determine that it is indeed a V4L2 device, there is currently no equivalent for v4l-subdev nodes. Adding this ioctl will solve that, and it will allow utilities like v4l2-compliance to be used with these devices as well. SUBDEV_QUERYCAP currently returns the version, device_caps and the entity_id of the subdevice (if there is any). Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> --- drivers/media/v4l2-core/v4l2-subdev.c | 17 +++++++++++++++++ include/uapi/linux/v4l2-subdev.h | 18 ++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 6359606..160a91a 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -25,6 +25,7 @@ #include <linux/types.h> #include <linux/videodev2.h> #include <linux/export.h> +#include <linux/version.h> #include <media/v4l2-ctrls.h> #include <media/v4l2-device.h> @@ -187,6 +188,22 @@ static long subdev_do_ioctl(struct file *file, unsigned int cmd, void *arg) #endif switch (cmd) { + case VIDIOC_SUBDEV_QUERYCAP: { + struct v4l2_subdev_capability *cap = arg; + + cap->version = LINUX_VERSION_CODE; + cap->device_caps = 0; + cap->entity_id = 0; +#if defined(CONFIG_MEDIA_CONTROLLER) + if (sd->entity.parent) { + cap->device_caps = V4L2_SUBDEV_CAP_ENTITY; + cap->entity_id = sd->entity.id; + } +#endif + memset(cap->reserved, 0, sizeof(cap->reserved)); + break; + } + case VIDIOC_QUERYCTRL: return v4l2_queryctrl(vfh->ctrl_handler, arg); diff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h index dbce2b5..d92ffbf 100644 --- a/include/uapi/linux/v4l2-subdev.h +++ b/include/uapi/linux/v4l2-subdev.h @@ -154,9 +154,27 @@ struct v4l2_subdev_selection { __u32 reserved[8]; }; +/** + * struct v4l2_subdev_capability - subdev capabilities + * @version: the kernel version + * @device_caps: the subdev capabilities + * @entity_id: the entity ID if V4L2_SUBDEV_CAP_ENTITY is set + * @reserved: for future use, set to zero for now + */ +struct v4l2_subdev_capability { + __u32 version; + __u32 device_caps; + __u32 entity_id; + __u32 reserved[29]; +}; + +/* This v4l2_subdev is also a media entity and the entity_id field is valid */ +#define V4L2_SUBDEV_CAP_ENTITY (1 << 0) + /* Backwards compatibility define --- to be removed */ #define v4l2_subdev_edid v4l2_edid +#define VIDIOC_SUBDEV_QUERYCAP _IOR('V', 0, struct v4l2_subdev_capability) #define VIDIOC_SUBDEV_G_FMT _IOWR('V', 4, struct v4l2_subdev_format) #define VIDIOC_SUBDEV_S_FMT _IOWR('V', 5, struct v4l2_subdev_format) #define VIDIOC_SUBDEV_G_FRAME_INTERVAL _IOWR('V', 21, struct v4l2_subdev_frame_interval) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html