Am Freitag, den 26.06.2015, 10:28 +0200 schrieb Sylwester Nawrocki: [...] > >> How about modifying v4l2_m2m_ioctl_reqbufs() instead ? > > > > The coda, gsc-m2m, m2m-deinterlace, mx2_emmaprp, and sh_veu drivers all > > have their own implementation of vidioc_reqbufs that call > > v4l2_m2m_reqbufs directly. > > Maybe this should be moved into v4l2_m2m_ioctl_reqbufs after all drivers > > are updated to use it instead of v4l2_m2m_reqbufs. > > In case of some of the above listed drivers it shouldn't be difficult > and would be nice to convert to the generic v4l2_m2m_ioctl* callbacks. > > Anyway, I guess your code change makes sense, just the comment might > be a little bit misleading. vq->owner will always be one and the same > file handle, unless I'm missing something. True. Since the m2m_ctx containing the vb2_queue is attached to the file handle, this will only ever get called with the same file handle for a given queue. s/we have a new owner/we have an owner/ ? [...] > > Having the queue owner's device minor in the trace output is very useful > > when tracing a single stream across multiple devices. To discern events > > from multiple simultaneous contexts I have added the context id to the > > coda driver specific trace events. > > OK, I understand now, you are just using this stored file handle for traces. I should mention this in the patch description. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
