Re: [PATCH 2/2] [media] videobuf2: add trace events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Donnerstag, den 25.06.2015, 09:07 -0400 schrieb Steven Rostedt:
> On Thu, 25 Jun 2015 12:01:27 +0200
> Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
> 
> > diff --git a/include/trace/events/v4l2.h b/include/trace/events/v4l2.h
> > index 89d0497..3d15cf1 100644
> > --- a/include/trace/events/v4l2.h
> > +++ b/include/trace/events/v4l2.h
> > @@ -175,9 +175,108 @@ SHOW_FIELD
> >  		)							\
> >  	)
> >  
> > +#define VB2_TRACE_EVENT(event_name)					\
> 
> This is what we have DECLARE_EVENT_CLASS for. Please use that,
> otherwise you are adding about 5k of text per event (where as
> DEFINE_EVENT adds only about 250 bytes).
[...]
> While you are at it, nuke the above macro and convert that too.

Thanks, I'll do that.

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux