Hi Lars-Peter, On Thu, Jun 25, 2015 at 11:22:02AM +0200, Lars-Peter Clausen wrote: > On 06/25/2015 11:12 AM, Sakari Ailus wrote: > >Hi Hans, > > > >On Tue, Jun 23, 2015 at 11:20:23AM +0200, Hans Verkuil wrote: > >>If the vdev pointer == NULL, then just return. > >> > >>This makes it easier for subdev drivers to use this function without having to > >>check if the sd->devnode pointer is NULL or not. > > > >Do you have an example of when this would be useful? Isn't it a rather > >fundamental question to a driver whether or not it exposes a device node, > >i.e. why would a driver use v4l2_event_queue() in the first place if it does > >not expose a device node, and so the event interface? > > The device node will only be created if the subdev driver supports it and if > the bridge driver requests it. So if the subdev driver supports it, but the > bridge driver does not request it there will be no devnode. The patch is to > handle that case. > > This patch is a requirement for this series which adds support for direct > event notification to some subdev drivers. Why this is necessary and useful > can be found in the series patch description. > http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/92808 Ok, fair enough. Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
