On Fri 2015-06-12 09:47:28, Uwe Kleine-König wrote:
> Without setting the direction of a gpio to output a call to
> gpiod_set_value doesn't have a defined outcome.
>
> Furthermore this is one caller less that stops us making the flags
> argument to gpiod_get*() mandatory.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Acked-by: Pavel Machek <pavel@xxxxxx>
> diff --git a/drivers/media/i2c/adp1653.c b/drivers/media/i2c/adp1653.c
> index c70ababce954..5dd39775d6ca 100644
> --- a/drivers/media/i2c/adp1653.c
> +++ b/drivers/media/i2c/adp1653.c
> @@ -465,7 +465,7 @@ static int adp1653_of_init(struct i2c_client *client,
>
> of_node_put(child);
>
> - pd->enable_gpio = devm_gpiod_get(&client->dev, "enable");
> + pd->enable_gpio = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
> if (!pd->enable_gpio) {
> dev_err(&client->dev, "Error getting GPIO\n");
> return -EINVAL;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
