On Wed, Jun 10, 2015 at 2:34 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> Hi Bryan,
>
> On Wed, Jun 10, 2015 at 11:12:50AM -0700, Bryan Wu wrote:
>> On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu <cooloney@xxxxxxxxx> wrote:
>> > On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu <cooloney@xxxxxxxxx> wrote:
>> >> On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski
>> >> <j.anaszewski@xxxxxxxxxxx> wrote:
>> >>> This patch adds helper functions for registering/unregistering
>> >>> LED Flash class devices as V4L2 sub-devices. The functions should
>> >>> be called from the LED subsystem device driver. In case the
>> >>> support for V4L2 Flash sub-devices is disabled in the kernel
>> >>> config the functions' empty versions will be used.
>> >>>
>> >>
>> >> Please go ahead with my Ack
>> >>
>> >> Acked-by: Bryan Wu <cooloney@xxxxxxxxx>
>> >>
>> >
>> > I found the rest of LED patches depend on this one. What about merging
>> > this through my tree?
>> >
>> > -Bryan
>> >
>> >
>>
>> Merged into my -devel branch and it won't be merged into 4.2.0 merge
>> window but wait for one more cycle, since now it's quite late in 4.1.0
>> cycle.
>
> Thanks!!
>
> I briefly discussed this with Mauro (cc'd), this should be fine indeed.
>
I just got an email reporting a building error.
tree: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git
devel
head: c7551d847a2336c299dff27b33ff48913fb11ee3
commit: badd9dba592c55f7a7b1f2b59ecdf0345ca56f01 [23/26] media: Add
registration helpers for V4L2 flash sub-devices
config: i386-allyesconfig (attached as .config)
reproduce:
git checkout badd9dba592c55f7a7b1f2b59ecdf0345ca56f01
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
drivers/media/v4l2-core/v4l2-flash-led-class.c: In function
'v4l2_flash_init':
drivers/media/v4l2-core/v4l2-flash-led-class.c:646:4: error: 'struct
v4l2_subdev' has no member named 'of_node'
sd->of_node = of_node;
^
drivers/media/v4l2-core/v4l2-flash-led-class.c:662:8: error:
'struct v4l2_subdev' has no member named 'of_node'
if (sd->of_node)
^
drivers/media/v4l2-core/v4l2-flash-led-class.c:663:17: error:
'struct v4l2_subdev' has no member named 'of_node'
of_node_get(sd->of_node);
^
drivers/media/v4l2-core/v4l2-flash-led-class.c: In function
'v4l2_flash_release':
drivers/media/v4l2-core/v4l2-flash-led-class.c:696:8: error:
'struct v4l2_subdev' has no member named 'of_node'
if (sd->of_node)
^
drivers/media/v4l2-core/v4l2-flash-led-class.c:697:17: error:
'struct v4l2_subdev' has no member named 'of_node'
of_node_put(sd->of_node);
^
vim +646 drivers/media/v4l2-core/v4l2-flash-led-class.c
640
641 sd = &v4l2_flash->sd;
642 v4l2_flash->fled_cdev = fled_cdev;
643 v4l2_flash->iled_cdev = iled_cdev;
644 v4l2_flash->ops = ops;
645 sd->dev = dev;
> 646 sd->of_node = of_node;
647 v4l2_subdev_init(sd, &v4l2_flash_subdev_ops);
648 sd->internal_ops = &v4l2_flash_subdev_internal_ops;
649 sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
