On Fri 2015-06-05 13:34:01, Hans Verkuil wrote: > On 05/15/2015 11:31 PM, Pali Rohár wrote: > > From: maxx <maxx@xxxxxxxxxxxxx> > > > > This enables access to automute function of the chip via sysfs and > > gives direct access to FM_AUDIO_CTRL0/1 registers, also via sysfs. I > > don't think this is so important but helps in developing radio scanner > > apps. > > > > Patch writen by maxx@xxxxxxxxxxxxx > > > > Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > Cc: maxx@xxxxxxxxxxxxx > > As Pavel mentioned, these patches need to be resend with correct Signed-off-by > lines. > > Regarding this patch: I don't want to apply this since this really should be a > control. Or just enable it always. If someone wants to make this a control, then > let me know: there are two other drivers with an AUTOMUTE control: bttv and saa7134. > > In both cases it is implemented as a private control, but it makes sense to > promote this to a standard user control. I can make a patch for that. > > And for CTRL0/1: if you want direct register access, then implement > VIDIOC_DBG_G/S_REGISTER. This makes sure you have the right permissions etc. > > More importantly: is anyone working on getting this driver out of staging? It's > been here for about a year and a half and I haven't seen any efforts to clean it up. Yes, there are. Unfortunately, this one depends on bluetooth driver, and we have some fun with that one. So please be patient... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
