Em Fri, 05 Jun 2015 16:00:43 +0100 Sean Young <sean@xxxxxxxx> escreveu: > On Fri, Jun 05, 2015 at 03:55:38PM +0100, Sean Young wrote: > > On Fri, Jun 05, 2015 at 11:27:41AM -0300, Mauro Carvalho Chehab wrote: > > > Don't assume that IR_MAX_DURATION is a bitmask. It isn't. > > > > The patch is right, but note that IR_MAX_DURATION is 0xffffffff, and in > > all these cases it is being compared to a u32, so it is always false. > > > > Should these statements simply be removed? None of the other drivers > > do these checks. > > Sorry please ignore me, I should have read the whole patch series. :( Yeah, patch 9/11 addresses it. We'll very likely need a check against a maximum value. The Y2038 patches converting several timestamps to 64 bits. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
