Re: [PATCH] Improve Y16 color setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hans


On Mon, Jun 1, 2015 at 9:05 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> Currently the colors for the Y16 and Y16_BE pixelformats are in the range
> 0x0000-0xff00. So pure white (0xffff) is never created.
>
> Improve this by using the same byte for both LSB and MSB so the full range
> is achieved.


If someone uses vivid as reference (I sometimes do), this could lead
to incorrect implementations. If the user don't implement the
endianess right he will never notice. I have carried out an endianness
bug for some months, until gstreamer was showing "funny" ;) images.

If the problem is that you want to reach saturation, I would rather
setting the lsb to 0xff all the time. (i.e. going from 0x00ff to
0xffff).

If we want saturation and zero, we could set the lsb to val?0xff:0;



Regards!
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux