Em Thu, 28 May 2015 23:57:56 +0200
Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
> On 05/28/2015 11:49 PM, Mauro Carvalho Chehab wrote:
> > Using typedefs is already bad enough, but doing it together
> > with enum declaration is even worse.
> >
> > Also, it breaks the scripts at DocBook that would be generating
> > reference pointers for the enums.
> >
> > Well, we can't get rid of typedef right now, but let's at least
> > declare it on a separate line, and let the scripts to generate
> > the cross-reference, as this is needed for the next DocBook
> > patches.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
> >
> > diff --git a/include/uapi/linux/dvb/frontend.h b/include/uapi/linux/dvb/frontend.h
> > index 466f56997272..7aeeb5a69fdf 100644
> > --- a/include/uapi/linux/dvb/frontend.h
> > +++ b/include/uapi/linux/dvb/frontend.h
> > @@ -36,7 +36,7 @@ typedef enum fe_type {
> > } fe_type_t;
> >
> >
> > -typedef enum fe_caps {
> > +enum fe_caps {
> > FE_IS_STUPID = 0,
> > FE_CAN_INVERSION_AUTO = 0x1,
> > FE_CAN_FEC_1_2 = 0x2,
> > @@ -68,7 +68,9 @@ typedef enum fe_caps {
> > FE_NEEDS_BENDING = 0x20000000, /* not supported anymore, don't use (frontend requires frequency bending) */
> > FE_CAN_RECOVER = 0x40000000, /* frontend can recover from a cable unplug automatically */
> > FE_CAN_MUTE_TS = 0x80000000 /* frontend can stop spurious TS data output */
> > -} fe_caps_t;
> > +};
> > +
> > +typedef enum fe_caps_t;
>
> This can't be right. This should be:
>
> typedef enum fe_caps fe_caps_t;
>
> Does it even compile?
>
> Regards,
>
> Hans
Heh, true. Thanks for checking.
Yeah, this won't likely compile.
I'll double check the building troubles and fix them.
Thanks for pointing it.
Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
