Hi Hans, On Monday 25 May 2015 00:25:36 Hans Verkuil wrote: > On 05/24/2015 11:10 PM, Laurent Pinchart wrote: > > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxx> > > > > Add a new subdev operation to initialize a subdev pad config array, and > > a helper function to allocate and initialize the array. This can be used > > by bridge drivers to implement try format based on subdev pad > > operations. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxx> > > Acked-by: Vaibhav Hiremath <vaibhav.hiremath@xxxxxxxxxx> > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > Note that before this goes in there should be at least one subdev driver > that implements init_cfg(). Perhaps adv7604? I fully agree, this needs to be used by at least one subdev driver. I'd go even further, I'd like to see v4l2_subdev_alloc_pad_config() used by a bridge driver, to implement VIDIOC_TRY_FMT. I've originally written the patch to implement VIDIOC_TRY_FMT (and VIDIOC_ENUM_FRAMESIZES) in a driver I'm developing, but it's not ready for submission to mainline yet. Do you think a subdev driver is enough, or do we need a bridge too in order to merge this patch ? > > --- > > > > drivers/media/v4l2-core/v4l2-subdev.c | 19 ++++++++++++++++++- > > include/media/v4l2-subdev.h | 10 ++++++++++ > > 2 files changed, 28 insertions(+), 1 deletion(-) > > > > Changes since v1: > > > > - Added v4l2_subdev_free_pad_config -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
