On 21/05/15 06:58, Hans Verkuil wrote: > On 05/20/2015 06:39 PM, William Towle wrote: >> Fill in bus_info field and zero reserved field. >> >> Signed-off-by: Rob Taylor <rob.taylor@xxxxxxxxxxxxxxx> >> Reviewed-by: William Towle <william.towle@xxxxxxxxxxxxxxx> >> --- >> drivers/media/platform/soc_camera/soc_camera.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c >> index fd7497e..583c5e6 100644 >> --- a/drivers/media/platform/soc_camera/soc_camera.c >> +++ b/drivers/media/platform/soc_camera/soc_camera.c >> @@ -954,6 +954,8 @@ static int soc_camera_querycap(struct file *file, void *priv, >> WARN_ON(priv != file->private_data); >> >> strlcpy(cap->driver, ici->drv_name, sizeof(cap->driver)); >> + strlcpy(cap->bus_info, "platform:soc_camera", sizeof(cap->bus_info)); >> + memset(cap->reserved, 0, sizeof(cap->reserved)); > > Why the memset? That shouldn't be needed. v4l2-complience complained it wasn't zero (v4l2-compliance.cpp:308 in v4l-utils v1.6.2 [1]) Thanks, Rob [1] http://git.linuxtv.org/cgit.cgi/v4l-utils.git/tree/utils/v4l2-compliance/v4l2-compliance.cpp?id=v4l-utils-1.6.2#n308 > Regards, > > Hans > >> return ici->ops->querycap(ici, cap); >> } >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
