Hello.
On 05/20/2015 07:39 PM, William Towle wrote:
Add detection of source pad number for drivers aware of the media
controller API, so that soc_camera/rcar_vin can create device nodes
to support a driver such as adv7604.c (for HDMI on Lager) underneath.
Signed-off-by: William Towle <william.towle@xxxxxxxxxxxxxxx>
Reviewed-by: Rob Taylor <rob.taylor@xxxxxxxxxxxxxxx>
---
drivers/media/platform/soc_camera/rcar_vin.c | 4 ++++
drivers/media/platform/soc_camera/soc_camera.c | 27 +++++++++++++++++++++++-
include/media/soc_camera.h | 1 +
3 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index 0f67646..b4e9b43 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
[...]
diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c
index d708df4..126d645 100644
--- a/drivers/media/platform/soc_camera/soc_camera.c
+++ b/drivers/media/platform/soc_camera/soc_camera.c
[...]
@@ -1311,7 +1312,25 @@ static int soc_camera_probe_finish(struct soc_camera_device *icd)
}
/* At this point client .probe() should have run already */
- ret = soc_camera_init_user_formats(icd);
+ ret = media_entity_init(&icd->vdev->entity, 1, &icd->pad, 0);
+ if (!ret) {
+ for (src_pad_idx = 0; src_pad_idx < sd->entity.num_pads;
+ src_pad_idx++)
+ if (sd->entity.pads[src_pad_idx].flags
+ == MEDIA_PAD_FL_SOURCE)
+ break;
+
+ if (src_pad_idx < sd->entity.num_pads) {
+ if (!media_entity_create_link(
+ &icd->vdev->entity, 0,
+ &sd->entity, src_pad_idx,
+ MEDIA_LNK_FL_IMMUTABLE |
+ MEDIA_LNK_FL_ENABLED)) {
Please either start the continuation lines under ! on the first line or
indent them more to the right, so that's easier on the eyes.
+ ret = soc_camera_init_user_formats(icd);
+ }
+ }
+ }
+
if (ret < 0)
goto eusrfmt;
@@ -1322,6 +1341,7 @@ static int soc_camera_probe_finish(struct soc_camera_device *icd)
goto evidstart;
/* Try to improve our guess of a reasonable window format */
+ fmt.pad = src_pad_idx;
if (!v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt)) {
icd->user_width = mf->width;
icd->user_height = mf->height;
@@ -1335,6 +1355,7 @@ static int soc_camera_probe_finish(struct soc_camera_device *icd)
evidstart:
soc_camera_free_user_formats(icd);
eusrfmt:
+ media_entity_cleanup(&icd->vdev->entity);
soc_camera_remove_device(icd);
return ret;
@@ -1856,6 +1877,10 @@ static int soc_camera_remove(struct soc_camera_device *icd)
if (icd->num_user_formats)
soc_camera_free_user_formats(icd);
+ if (icd->vdev->entity.num_pads) {
+ media_entity_cleanup(&icd->vdev->entity);
+ }
+
Brackets not needed here, and checkpatch.pl should have complained about that.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
