Re: [PATCH 1/3] cx24120: don't initialize a var that won't be used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro, 

On Tue, 19 May 2015 08:23:36 -0300 Mauro Carvalho Chehab
<mchehab@xxxxxxxxxxxxxxx> wrote:

> As reported by smatch:
> drivers/media/dvb-frontends/cx24120.c: In function 'cx24120_message_send':
> drivers/media/dvb-frontends/cx24120.c:368:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
>   int ret, ficus;
>       ^
> 
> The values written by cx24120 are never checked. So, remove the
> check here too. That's said, the best would be to do the reverse,
> but globally: to properly handle the error codes.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>

Woudl you mind me integrating your patches on my tree which I then
will ask you to pull?

--
Patrick.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux