Hi Kamil, It seems that you've only incorporated the libgencec.pc suggestion. Did you change your mind about the others, found out something funny with them (if so can you let me know what) or simply forgot about them ? On 30 April 2015 at 11:25, Kamil Debski <k.debski@xxxxxxxxxxx> wrote: > Hi Emil, > > From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- > owner@xxxxxxxxxxxxxxx] On Behalf Of Emil Velikov > Sent: Wednesday, April 29, 2015 5:00 PM >> >> Hi Kamil, >> >> Allow me to put a few suggestions: >> >> On 29 April 2015 at 11:02, Kamil Debski <k.debski@xxxxxxxxxxx> wrote: >> > diff --git a/m4/.gitkeep b/m4/.gitkeep new file mode 100644 index >> > 0000000..e69de29 >> Haven't seen any projects doing this. Curious what the benefits of >> keeping and empty folder might be ? > > When I run autoreconf -i it complained about missing m4 folder, hence I added > this filler file such that the folder is created. Any suggestion on how to do > this better? > Ahh yes - that lovely message. It turns out that older versions of automake will even error out [1], rather than just printing out a warning. A handy workaround would be to add a .gitignore (and a second one in the top folder) list. Plus it will slim down the untracked files list and let you clearly see when git add was missed :-) Cheers Emil [1] https://bugzilla.redhat.com/show_bug.cgi?id=901333 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
