Em Fri, 10 Apr 2015 22:28:33 +0100 Lad Prabhakar <prabhakar.csengg@xxxxxxxxx> escreveu: > From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> > > this patch adds dependency of VIDEO_V4L2_SUBDEV_API > for VIDEO_OV2659 so that it doesn't complain for random > config builds. Actually, this doesn't seem right. Why should this driver depend on an optional API? It should be possible to use it on some bridge driver that doesn't expose the subdev API. So, please fix it the other way, by making subdev API optional on it. Regards, Mauro > > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> > --- > drivers/media/i2c/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 6f30ea7..8b05681 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -468,7 +468,7 @@ config VIDEO_SMIAPP_PLL > > config VIDEO_OV2659 > tristate "OmniVision OV2659 sensor support" > - depends on VIDEO_V4L2 && I2C > + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API > depends on MEDIA_CAMERA_SUPPORT > ---help--- > This is a Video4Linux2 sensor-level driver for the OmniVision -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
