On 04/29/2015 01:04 AM, Mauro Carvalho Chehab wrote:
> As reported by smatch:
> drivers/media/usb/go7007/go7007-driver.c:452 frame_boundary() warn: variable dereferenced before check 'vb' (see line 449)
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> diff --git a/drivers/media/usb/go7007/go7007-driver.c b/drivers/media/usb/go7007/go7007-driver.c
> index 95cffb771a62..0ab81ec8897a 100644
> --- a/drivers/media/usb/go7007/go7007-driver.c
> +++ b/drivers/media/usb/go7007/go7007-driver.c
> @@ -446,7 +446,7 @@ static void go7007_motion_regions(struct go7007 *go, struct go7007_buffer *vb)
> */
> static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buffer *vb)
> {
> - u32 *bytesused = &vb->vb.v4l2_planes[0].bytesused;
> + u32 *bytesused;
> struct go7007_buffer *vb_tmp = NULL;
>
> if (vb == NULL) {
> @@ -458,6 +458,7 @@ static struct go7007_buffer *frame_boundary(struct go7007 *go, struct go7007_buf
> go->next_seq++;
> return vb;
> }
> + bytesused = &vb->vb.v4l2_planes[0].bytesused;
>
> vb->vb.v4l2_buf.sequence = go->next_seq++;
> if (vb->modet_active && *bytesused + 216 < GO7007_BUF_SIZE)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
