Hi Mauro, On Mon, 27 Apr 2015 21:40:22 -0300 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx> wrote: > > Could we send an additional patch for coding-style or would you prefer > > a new patch which has everything inside? This would maintain the > > author-attribution of the initial commit. > > An additional patch is fine. I fixed the files cx24120.[ch] in a --strict manner. Do you want me to send each of these patches to the list? They are not really interesting. But if it might help to review for any obvious mistakes... I rebased my tree on the media-tree of this morning. I checked the fe_stat-stuff and I saw that you need to keep the old unc, ber and snr functions anyway. I doubt that the cx24120 in its current state reports anything useful for statistical uses. Do you think there is an added value adding it to a driver which is very simple in this regards? Regarding the wait for channel-lock I think it could be written differently using a state and checking in the get_status-function whether it is locked for the first time. This will need testing. I haven't done it yet. regards, -- Patrick. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
