Hi Tycho, Yes, so far the only device that I know should use gapped clock is the DVBSky T330 a.k.a. TechnoTrend CT2-4400. I've also seen that the Hauppauge HVR-2205 Windows driver enables this option, but it seems to me that that board works ok also without this. Cheers, -olli On 24 April 2015 at 09:01, Olli Salonen <olli.salonen@xxxxxx> wrote: > Hi Tycho, > > Yes, so far the only device that I know should use gapped clock is the > DVBSky T330 a.k.a. TechnoTrend CT2-4400. > > I've also seen that the Hauppauge HVR-2205 Windows driver enables this > option, but it seems to me that that board works ok also without this. > > Cheers, > -olli > > On 24 April 2015 at 08:57, Tycho Lürsen <tycholursen@xxxxxxxxx> wrote: >> >> One more question: >> >> cx23885-dvb.c (and maybe others) contains a couple of instances of >> >> si2168_config.ts_mode = SI2168_TS_PARALLEL; >> and >> si2168_config.ts_mode = SI2168_TS_SERIAL; >> >> But you don't patch them with >> >> si2168_config.ts_clock_gapped = true; >> >> Is this intentional? >> >> Kind regards, >> Tycho >> >> Op 23-04-15 om 23:11 schreef Olli Salonen: >>> >>> Change the dvbsky driver to support gapped clock instead of the current >>> hack. >>> >>> Signed-off-by: Olli Salonen <olli.salonen@xxxxxx> >>> --- >>> drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> b/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> index cdf59bc..0f73b1d 100644 >>> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c >>> @@ -615,7 +615,8 @@ static int dvbsky_t330_attach(struct dvb_usb_adapter >>> *adap) >>> memset(&si2168_config, 0, sizeof(si2168_config)); >>> si2168_config.i2c_adapter = &i2c_adapter; >>> si2168_config.fe = &adap->fe[0]; >>> - si2168_config.ts_mode = SI2168_TS_PARALLEL | 0x40; >>> + si2168_config.ts_mode = SI2168_TS_PARALLEL; >>> + si2168_config.ts_clock_gapped = true; >>> memset(&info, 0, sizeof(struct i2c_board_info)); >>> strlcpy(info.type, "si2168", I2C_NAME_SIZE); >>> info.addr = 0x64; >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
